add children to typings to support removal of same in react 18 typings#818
Closed
aesser wants to merge 1 commit intotomkp:masterfrom
Closed
add children to typings to support removal of same in react 18 typings#818aesser wants to merge 1 commit intotomkp:masterfrom
aesser wants to merge 1 commit intotomkp:masterfrom
Conversation
Owner
|
Thank you for this contribution! This issue has been fixed in v3.0.0, which includes a complete TypeScript rewrite with proper type definitions including the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current typing definition will cause the following error when upgrading to React 18 typing definitions
Property 'children' does not exist on type 'IntrinsicAttributes & IntrinsicClassAttributes & Pick<Readonly, never>
This PR adds the children prop.
See also SO answer as reference:
https://stackoverflow.com/questions/71788254/react-18-typescript-children-fc/71809927#71809927